Skip to content

Try to log exceptions in IoThread #14899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 2 commits into from
May 4, 2023
Merged

Try to log exceptions in IoThread #14899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c33c80
Try to log exceptions in IoThread
LeonarddeR May 3, 2023
3389fbd
Log all the stacks
LeonarddeR May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions source/hwIo/ioThread.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
from inspect import ismethod
from buildVersion import version_year
import NVDAState
from watchdog import getFormattedStacksForAllThreads

@CyrilleB79 CyrilleB79 May 4, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is not used only for watchdog, would it be worth to move getFormattedStacksForAllThreads in a log-related file? E.g. logHandler.py

With watchdog.getFormattedStacksForAllThreads remaining but being deprecated.

@LeonarddeR LeonarddeR May 4, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense, but then we could also extend the stack_info argument to take something to log all stacks. That might be something more suitable for a follow up.


LPOVERLAPPED_COMPLETION_ROUTINE = ctypes.WINFUNCTYPE(
None,
Expand Down Expand Up @@ -197,7 +198,12 @@ def fakeApc(param):
self.handle = None

def run(self):
while True:
ctypes.windll.kernel32.SleepEx(winKernel.INFINITE, True)
if self.exit:
break
try:
while True:
ctypes.windll.kernel32.SleepEx(winKernel.INFINITE, True)
if self.exit:
break
except Exception:
log.critical("Exception in IoThread function", exc_info=True)
stacks = getFormattedStacksForAllThreads()
log.info(f"Listing stacks for Python threads after IoThread crash:\n{stacks}")