Skip to content

Use line as a unit for which say all is moved in rich edit controls #13971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 2 commits into from
Aug 2, 2022
Merged

Use line as a unit for which say all is moved in rich edit controls #13971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0837ce2
Use line as a unit for which say all is moved in rich edit controls
lukaszgo1 Aug 1, 2022
3288f67
update changes
seanbudd Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 9 additions & 16 deletions source/NVDAObjects/window/edit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,38 +3,30 @@
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.

import locale
from typing import (
Dict,
Optional,
)

import comtypes.client
import struct
import ctypes
from comtypes import COMError
import oleTypes
import colors
import globalVars
import NVDAHelper
import eventHandler
import comInterfaces.tom
from logHandler import log
import languageHandler
import config
import speech
import winKernel
import api
import winUser
import textInfos.offsets
from keyboardHandler import KeyboardInputGesture
from scriptHandler import isScriptWaiting
import controlTypes
from controlTypes import TextPosition
from . import Window
from .. import NVDAObjectTextInfo
from ..behaviors import EditableTextWithAutoSelectDetection
import braille
import watchdog
import locationHelper
import textUtils
Expand Down Expand Up @@ -465,16 +457,17 @@ def _getParagraphOffsets(self,offset):
comInterfaces.tom.tomStory:textInfos.UNIT_STORY,
}

NVDAUnitsToITextDocumentUnits={
textInfos.UNIT_CHARACTER:comInterfaces.tom.tomCharacter,
textInfos.UNIT_WORD:comInterfaces.tom.tomWord,
textInfos.UNIT_LINE:comInterfaces.tom.tomLine,
textInfos.UNIT_SENTENCE:comInterfaces.tom.tomSentence,
textInfos.UNIT_PARAGRAPH:comInterfaces.tom.tomParagraph,
textInfos.UNIT_STORY:comInterfaces.tom.tomStory,
textInfos.UNIT_READINGCHUNK:comInterfaces.tom.tomSentence,
NVDAUnitsToITextDocumentUnits: Dict[str, int] = {
textInfos.UNIT_CHARACTER: comInterfaces.tom.tomCharacter,
textInfos.UNIT_WORD: comInterfaces.tom.tomWord,
textInfos.UNIT_LINE: comInterfaces.tom.tomLine,
textInfos.UNIT_SENTENCE: comInterfaces.tom.tomSentence,
textInfos.UNIT_PARAGRAPH: comInterfaces.tom.tomParagraph,
textInfos.UNIT_STORY: comInterfaces.tom.tomStory,
textInfos.UNIT_READINGCHUNK: comInterfaces.tom.tomLine,
}


class ITextDocumentTextInfo(textInfos.TextInfo):

def _get_pointAtStart(self):
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ What's New in NVDA
== Bug Fixes ==
- When updating NVDA using the Windows Package Manager CLI (aka winget), a released version of NVDA is no longer always treated as newer than whatever alpha version is installed. (#12469)
- NVDA will now correctly announce Group boxes in Java applications. (#13962)
- Caret properly follows spoken text in say all in applications such as Bookworm, WordPad, or the NVDA log viewer. (#13420, #9179)
-


Expand Down