Skip to content

Remove deprecated loadState and saveState from addonHandler #13245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 3 commits into from
Jan 18, 2022
Merged

Remove deprecated loadState and saveState from addonHandler #13245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6636ee2
Remove deprecated loadState and saveState from addonHandler
lukaszgo1 Jan 17, 2022
f960d40
Merge branch 'master' into addonHandlerRemoveDeprecatedFunctions
seanbudd Jan 18, 2022
60d4af8
update changes
seanbudd Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions source/addonHandler/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# A part of NonVisual Desktop Access (NVDA)
# Copyright (C) 2012-2021 Rui Batista, NV Access Limited, Noelia Ruiz Martínez,
# Copyright (C) 2012-2022 Rui Batista, NV Access Limited, Noelia Ruiz Martínez,
# Joseph Lee, Babbage B.V., Arnold Loubriat, Łukasz Golonka
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.
Expand Down Expand Up @@ -30,7 +30,6 @@
from . import addonVersionCheck
from .addonVersionCheck import isAddonCompatible
import extensionPoints
import buildVersion


MANIFEST_FILENAME = "manifest.ini"
Expand Down Expand Up @@ -121,15 +120,6 @@ def cleanupRemovedDisabledAddons(self) -> None:
state = AddonsState()


# Deprecated - use `state.save` and `state.load` instead.
if buildVersion.version_year < 2022:
def saveState():
state.save()

def loadState():
state.load()


def getRunningAddons():
""" Returns currently loaded add-ons.
"""
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ This ensures code will honor the Windows user setting for swapping the primary m
- SCons now builds with multiple concurrent jobs, equal to the number of logical processors in the system.
This can dramatically decrease build times on multi core systems. (#13226)
- ``characterProcessing.SYMLVL_*`` constants are removed - please use ``characterProcessing.SymbolLevel.*`` instead. (#13248)
- Functions ``loadState`` and ``saveState`` are removed from addonHandler - please use ``addonHandler.state.load`` and ``addonHandler.state.save`` instead. (#13245)
-


Expand Down