Fix revert in 5b821c60a

[feerrenrut]

Link to issue number:

Fixes #12919

Summary of the issue:

When using NVDA with Libre / Open office Writer, text from the document can not be read.

In #12500 the variable used to iterate over _iterTextWithEmbeddedObjects was changed from field to textWithEmbeddedObjectsItem, additionally childObject was used instead of field for ti.obj.getChild(embedIndex)

In #12766 some of these changes were reverted, however textWithEmbeddedObjectsItem was no longer appended to fields instead field was.

Description of how this pull request fixes the issue:

Re-introduce renames.

Testing strategy:

Manually tested with OpenOffice:

• Create a new document with Writer
• Add text "This is a test"
• Start NVDA, navigate with arrow keys

The content should be read, no error sound should be heard.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English

[feerrenrut]

@michaelDCurran the case from #12766 will need to be retested.

[michaelDCurran]

I have confirmed that the Google Docs case in #12766 is still fixed. The Thunderbird case is very hard to reproduce, but I'll have much more of a chance to see it once running this code on beta or master for an extended period of time. Though I am quite confident the Thunderbird and Google Docs cases were the same bug.