Minor fixes in the User Guide and a GUI label regarding annotations options group - #12781
Merged
Merged
Conversation
michaelDCurran
approved these changes
Aug 25, 2021
Contributor
Author
|
@michaelDCurran, just to clarify, can you confirm explicitly that it is now too late to include the paragraph title modification in the beta branch? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Minor fixes of issues introduced by #12409 and #12500.
See @k-kolev1985 message in this thread on NVDA translation mailing-list for the initial reporting.
Summary of the issue:
Description of how this pull request fixes the issue:
Testing strategy:
Known issues with pull request:
Issue 2. is present in NVDA 2021.2beta1. However, since we are already in the translation freeze, I fear we cannot submit PR's affecting the User Guide targetting the beta branch.
Let me know if I am mistaken; in this case, I may open a separate PR for point 2. against targetting beta branch.
If on the contrary you confirm me that we cannot add User Guide changes in the beta branch, I may send an e-mail to the translators so that they use the matching group name in their translation. Thus the English User Guide may have the mistake but not the translated ones.
Change log entries:
Not needed.
Code Review Checklist: