Skip to content

prevent ExitDialog from being destroyed twice - #12403

Merged
seanbudd merged 1 commit into
masterfrom
prevent-exit-dialog-err
May 12, 2021
Merged

prevent ExitDialog from being destroyed twice#12403
seanbudd merged 1 commit into
masterfrom
prevent-exit-dialog-err

Conversation

@seanbudd

@seanbudd seanbudd commented May 12, 2021

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

the following error happens when exiting NVDA via NVDA+q exit dialog shows, then enter:

DEBUG - core._closeAllWindows (18:25:34.959) - MainThread (8636):
destroying main frame during exit process
ERROR - unhandled exception (18:25:34.959) - MainThread (8636):
Traceback (most recent call last):
  File "C:\work\repo\nvda\7\.venv\lib\site-packages\wx\core.py", line 3407, in <lambda>
    lambda event: event.callable(*event.args, **event.kw) )
RuntimeError: wrapped C/C++ object of type ExitDialog has been deleted

Description of how this pull request fixes the issue:

Prevents ExitDialog from being destroyed twice

Testing strategy:

Manual testing

Known issues with pull request:

None

Change log entries:

None, regression

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@seanbudd seanbudd added this to the 2021.1 milestone May 12, 2021
@seanbudd
seanbudd requested a review from a team as a code owner May 12, 2021 02:52
@seanbudd
seanbudd requested a review from michaelDCurran May 12, 2021 02:52
@AppVeyorBot

Copy link
Copy Markdown

@seanbudd
seanbudd requested a review from feerrenrut May 12, 2021 06:32

@feerrenrut feerrenrut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@seanbudd
seanbudd merged commit 5603440 into master May 12, 2021
@seanbudd
seanbudd deleted the prevent-exit-dialog-err branch May 12, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants