EditableText: Do not treat "\r\n" as two characters when backspace is pressed - #12379
Merged
michaelDCurran merged 1 commit intoMay 9, 2021
Conversation
michaelDCurran
approved these changes
May 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Found while investigating on #12375
Summary of the issue:
In Notepad++, when hitting
backspaceto delete a line break, NVDA announces "blank" instead of "new line".The
TextInfoof the Scintilla implementation may contain "\r\n" instead of "\n".The current implementation of
EditableText._backspaceScriptHelpertreats it as two characters and thus fails to trigger a proper announce.Description of how this pull request fixes the issue:
Replace "
\r\n" by "\n" before further treatment of the deleted chunk.Testing strategy:
Manually tested from a source copy with Notepad++ 7.8.7 and a bunch of other editors.
Known issues with pull request:
Change log entries:
I do not think this small fix deserves a change log entry.
Code Review Checklist: