Added release blurb and fixed grammar in api breaking sentence - #12376
Merged
Conversation
Contributor
|
Hi, In the release blurb: I think there is still a grammatical error with "add-on API" sentence, and may I suggest splitting that note into a separate line/paragraph? Thanks. |
feerrenrut
suggested changes
May 7, 2021
codeofdusk
reviewed
May 7, 2021
Thanks Reef! Co-authored-by: Reef Turner <feerrenrut@users.noreply.github.com>
Updated "maths" to "mathematics" as per Bill's request - thanks Bill! Also updated the wording of one of the bug fixes to fix the grammar. Changed from "... to use NVDA in a languages ..." to "... to use NVDA in languages ..." (Thanks Susanne via email for pointing that one out)
1 task
codeofdusk
reviewed
May 13, 2021
Updated "Mathematics" to "Mathematical" Co-authored-by: Bill Dengler <codeofdusk@gmail.com>
codeofdusk
approved these changes
May 13, 2021
feerrenrut
approved these changes
May 13, 2021
feerrenrut
left a comment
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Looks good @Qchristensen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Summary of the issue:
Needed a release blurb for 2021.1 and also there was a grammar error in the "API breaking sentence" in the what's new document.
Description of how this pull request fixes the issue:
With words
Testing strategy:
Read text, and ran past others when writing.
Known issues with pull request:
Change log entries:
For Developers
Code Review Checklist: