Focus chrome after starting in system tests - #12352
Merged
Merged
Conversation
seanbudd
force-pushed
the
better-systest-logging
branch
from
April 29, 2021 05:28
289c1ff to
938a56d
Compare
seanbudd
marked this pull request as ready for review
April 29, 2021 05:29
lukaszgo1
reviewed
Apr 29, 2021
lukaszgo1
reviewed
Apr 29, 2021
michaelDCurran
requested changes
Apr 30, 2021
michaelDCurran
left a comment
Member
There was a problem hiding this comment.
It may be an idea to add some kind of per-test unique value to testCaseTitle, because at the moment it is just "NVDA Browser Test Case". There is a small possibility the code could focus the wrong Chrome window, if one happened to be left arrround.
michaelDCurran
previously approved these changes
Apr 30, 2021
See test results for failed build of commit 4d87770046 |
See test results for failed build of commit b858e98797 |
seanbudd
dismissed
michaelDCurran’s stale review
April 30, 2021 04:09
I've changed hash -> abs(hash()) and changed the filter for the window search
michaelDCurran
approved these changes
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
As discussed in #12293, our systems fail randomly. Usually this is due to another window stealing focus, such as the taskbar or Docker. As system tests are run locally, we shouldn't be killing these processes.
Description of how this pull request fixes the issue:
Testing strategy:
Run the system tests locally, and prevent chrome from gaining focus by holding
alt+tabHere's an example log from a local test:
Known issues with pull request:
None
Change log entries:
None
Code Review Checklist: