Skip to content

Increase sleep to 5s after starting NVDA in chromeTests - #12343

Merged
seanbudd merged 1 commit into
masterfrom
increase-sleep
Apr 27, 2021
Merged

Increase sleep to 5s after starting NVDA in chromeTests#12343
seanbudd merged 1 commit into
masterfrom
increase-sleep

Conversation

@seanbudd

Copy link
Copy Markdown
Member

Link to issue number:

Follow up from #12293

Summary of the issue:

Chrome was still losing focus in systetests

These builds failed with the 2s sleep included due to taskbar gaining focus

Description of how this pull request fixes the issue:

Increase sleep time to 5s.

Testing strategy:

Low impact, see if system tests continue to fail due to taskbar gaining focus

Known issues with pull request:

  • Docker popups may still block the build: prevent Chrome losing focus during systests #12293 (comment) (I plan to follow up add better logging for this, and try to set them to re-run on appveyor)
  • 5s of sleep might not be long enough (we have confidence that 10s is)
  • Lint checking occasionally blocks builds due to a failed merge (I plan to follow up and fix this soon)

Change log entries:

None

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@seanbudd
seanbudd requested a review from a team as a code owner April 27, 2021 01:42
@seanbudd
seanbudd requested a review from michaelDCurran April 27, 2021 01:42
@seanbudd
seanbudd merged commit a0089a2 into master Apr 27, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Apr 27, 2021
@seanbudd
seanbudd deleted the increase-sleep branch April 27, 2021 02:06
@seanbudd seanbudd self-assigned this Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants