Skip to content

Braille Viewer: Add a close button on the title bar for use with pointing devices #12328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 3 commits into from
Apr 29, 2021
Merged

Braille Viewer: Add a close button on the title bar for use with pointing devices #12328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df8dfd5
Braille Viewer: Add a close button on the title bar for use with poin…
JulienCochuyt Apr 23, 2021
d3fc04c
Merge branch 'master' into i10791-brailleViewerCloseButton
seanbudd Apr 29, 2021
bd6ce2d
update changes.t2t
seanbudd Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/brailleViewer/brailleViewerGui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# A part of NonVisual Desktop Access (NVDA)
# Copyright (C) 2014-2019 NV Access Limited
# Copyright (C) 2014-2021 NV Access Limited, Accessolutions, Julien Cochuyt
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.
import enum
Expand Down Expand Up @@ -280,7 +280,7 @@ def __init__(self, numCells, onDestroyed):
gui.mainFrame,
title=self._title,
pos=dialogPos,
style=wx.CAPTION | wx.STAY_ON_TOP
style=wx.CAPTION | wx.CLOSE_BOX | wx.STAY_ON_TOP
)
self.Bind(wx.EVT_CLOSE, self._onClose)
self.Bind(wx.EVT_WINDOW_DESTROY, self._onDestroy)
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ What's New in NVDA
- Support for Adobe Flash content has been removed from NVDA due to the use of Flash being actively discouraged by Adobe. (#11131)
- NVDA will exit even with windows still open, the exit process now closes all NVDA windows and dialogs (#1740)
- The Speech Viewer can now be closed with `alt+F4` and has a standard close button for easier interaction with users of pointing devices. (#12330)
- The Braille Viewer now has a standard close button for easier interaction with users of pointing devices. (#12328)


== Bug Fixes ==
Expand Down