Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move report formatting changes box to the correct parent #12307

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Apr 19, 2021

Link to issue number:

None

Summary of the issue:

In #12181, the setting "Report formatting changes after the cursor" in "Document Formatting" was incorrectly moved to the wrong parent, the static box grouping above it, making it invisible to the user. It is currently readable using NVDA but not graphically visible to the user

This was noticed when testing #12300

Description of how this pull request fixes the issue:

Revert the change in #12181, making the parent the Settings Panel itself

Testing strategy:

Ensure the new control is visible

This can be done using the tools made in #12308

Known issues with pull request:

None

Change log entry:

None, regression

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

Copy link
Member

@michaelDCurran michaelDCurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an NVDA user I can also verify this fix, as before this pr NVDA would incorrectly announce the Elements grouping when shift tabbing from the Ok button to the Report Formatting changes after the cursor checkbox. This checkbox should not be in the Elements grouping. With this pr entering the Elements grouping is only announced when shift tabbing from okay, and again past this checkbox to the Clickable checkbox, which is again correct.

@seanbudd seanbudd merged commit f3306af into master Apr 20, 2021
@seanbudd seanbudd deleted the fix-detectFormattingBox branch April 20, 2021 23:40
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants