Skip to content

prevent Chrome losing focus during systests #12293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seanbudd merged 8 commits into from
Apr 21, 2021
Merged

prevent Chrome losing focus during systests #12293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
677a188
attempt to avoid NVDA losing focus during systests
seanbudd Apr 15, 2021
27cff53
fix lint
seanbudd Apr 15, 2021
a231d62
only call get last speech once
seanbudd Apr 15, 2021
9f4a8ac
log before firing postNvdaStartup notify event
seanbudd Apr 20, 2021
737cdb1
Merge branch 'master' into fix-systests-2
seanbudd Apr 20, 2021
9c7d9c2
add 2s sleep to system tests
seanbudd Apr 20, 2021
557cc70
Merge branch 'master' into fix-systests-2
seanbudd Apr 20, 2021
f19e481
revert killing docker
seanbudd Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion source/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,10 +584,16 @@ def run(self):
log.debug("initializing updateCheck")
updateCheck.initialize()
log.info("NVDA initialized")

# Queue the firing of the postNVDAStartup notification.
# This is queued so that it will run from within the core loop,
# and initial focus has been reported.
queueHandler.queueFunction(queueHandler.eventQueue, postNvdaStartup.notify)
def _doPostNvdaStartupAction():
log.debug("Notify of postNvdaStartup action")
postNvdaStartup.notify()

queueHandler.queueFunction(queueHandler.eventQueue, _doPostNvdaStartupAction)


log.debug("entering wx application main loop")
app.MainLoop()
Expand Down
3 changes: 1 addition & 2 deletions tests/system/libraries/SystemTestSpy/speechSpyGlobalPlugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,7 @@ def wait_for_NVDA_startup_to_complete(self):
giveUpAfterSeconds=self._minTimeout(10),
errorMessage="Unable to connect to nvdaSpy",
)
if self._isNvdaStartupComplete:
self.reset_all_speech_index()
self.reset_all_speech_index()

def get_last_speech(self) -> str:
return self._getSpeechAtIndex(-1)
Expand Down
6 changes: 5 additions & 1 deletion tests/system/robot/chromeTests.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Library NvdaLib.py
Library chromeTests.py
Library ScreenCapLibrary

Test Setup start NVDA standard-dontShowWelcomeDialog.ini
Test Setup default setup
Test Teardown default teardown

*** Keywords ***
Expand All @@ -22,6 +22,10 @@ default teardown
exit chrome
quit NVDA

default setup
start NVDA standard-dontShowWelcomeDialog.ini
Sleep 2s

*** Test Cases ***

checkbox labelled by inner element
Expand Down