Repository navigation
Exit NVDA safely by closing all top level windows #12183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 26 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
1ccdf8b
push crash dump as appveyor artifact
seanbudd c605479
create safeAppExit
seanbudd d57d486
remove unnecessary Destroy call
seanbudd bf9447e
check if crashDump exists before pushing
seanbudd 49eb9e7
revert d57d486941e63f04e9dd209ca3615325adb5dca0
seanbudd 684b9de
improve handling of welcomedialog closing
seanbudd 80e41ed
revert to previous behaviour to trigger appveyor crash dump
seanbudd 0e628c4
Revert "revert to previous behaviour to trigger appveyor crash dump"
seanbudd cbf39f6
add appveyor fail when crash dump on install process
seanbudd a469c4d
revert to previous behaviour to trigger appveyor crash dump
seanbudd 79aea67
Revert "revert to previous behaviour to trigger appveyor crash dump"
seanbudd eb89a33
add better comments
seanbudd a5dc8d3
rename installer crash file
seanbudd da7d307
improve commenting
seanbudd 6d7da7f
trigger appveyor crash
seanbudd 1abbbd9
Revert "trigger appveyor crash"
seanbudd 552711f
simplify appveyor push
seanbudd aacf6e1
Merge branch 'master' into fix-12153
seanbudd 05b8891
Merge remote-tracking branch 'origin/master' into fix-12153
seanbudd 8f577c2
move mainFrame exiting service to mainFrame, better logging
seanbudd d7aea3b
destroy the mainFrame to exit the App
seanbudd 439d7c0
fix lint
seanbudd 5475681
Merge branch 'master' into fix-12153
seanbudd 1fc0981
minimize diff
seanbudd c915591
handle all top level window desctruction from safe app exit
seanbudd 9eb32c7
use close behaviour where possible
seanbudd f5eba29
improved logging
seanbudd 7786252
update changes t2t
seanbudd 1564328
Merge remote-tracking branch 'origin/master' into fix-12153
seanbudd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.