Elements list is now available in Microsoft Word straight away without having to enable browse mode first - #12051
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
michaelDCurran
force-pushed
the
i12050
branch
from
February 9, 2021 01:36
945dfd9 to
6d29d7f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Have you tested this with the "Enable browse mode on page load" browse mode setting disabled? It should work fine, but just in case it doesn't... |
… a treeInterceptor created straight way, but with passThrough (focus mode) enabled. Thus, NVDA+f7 (elements list) is now available with out having to switch to browse mode in Microsoft Word first.
michaelDCurran
force-pushed
the
i12050
branch
from
February 10, 2021 21:02
6d29d7f to
844b589
Compare
Member
Author
|
NV Access has decided that this is too large of a change so close to a release. Thus it has now been rebased on master for NVDA 2021.1. |
7 tasks
7 tasks
michaelDCurran
added a commit
that referenced
this pull request
May 5, 2021
… now get a treeInterceptor created straight way, but with passThrough (focus mode) enabled. Thus, NVDA+f7 (elements list) is now available with out having to switch to browse mode in Microsoft Word first. (#12051)" (#12365) This reverts pr #12051 commit db664be. Fixes #12117 Summary of the issue: In both Outlook and Windows 10 Mail, a Microsoft Word document control is used to display content of received emails and emails currently being composed. In NVDA 2020.4, NVDA would use browse mode for reading emails, but not for writing emails. However, after merging of pr #12051 browse mode is no longer used by default when reading emails. This is because the base Microsoft Word document NVDAObject now creates a TreeInterceptor all the time, but set to focus mode, so that elements list is always available in Microsoft Word. But as hxMail and Outlook implementations assumed browse mode would be available for the TreeInterceptor always, and only created the TreeInterceptor in the reading pane, Windows 10 mail and Outlook ended up getting no treeInterceptor for writing email (ok) but for reading email it got a treeInterceptor but set to focus mode (not okay). Description of how this pull request fixes the issue: Reverts pr #12051 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12050
Summary of the issue:
Documentation for NVDA stated that Elements list (NVDA+f7) was available in focus mode. Although this wa strue for web documents and Excel, it was missed for Microsoft Word.
Description of how this pull request fixes the issue:
A treeInterceptor is now created for Microsoft Word documents (both with UIA enabled or disabled) but the treeInteceptor is defauled to focus mode. Thus Elements list is available straight away. This is the exact same approach as taken by the treeInterceptor for Microsoft Excel.
Testing strategy:
Manual testing done:
In theory a system test could be created for this, however this would require appveyor vms including Microsoft Word, which is something we would need to look into in the future.
I don't believe unit tests really apply to this kind of infrastructure change.
Known issues with pull request:
This change means that a treeInterceptor is now always created for Word documents. Although Word document treeInterceptors are not in any way heavy (they don't cache much at all) it is still a change which could affect the lifetime of treeInterceptors or other objects in NVDA.
I think this is very low risk, but either this needs to be tested on another rc for a while by heavy users of Microsoft Word, or we hold off until 2021.1 and make an edit to the 2020.4 documentation excluding Microsoft Word.
Change log entry:
None needed.
Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Please do a self-review to check these items.
Reviewers will not approve the PR until these are met.