Skip to content

Fix-up of PR 9724. Stop including empty properties when copying object to the clipboard #11441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelDCurran merged 3 commits into from
Aug 3, 2020
Merged

Fix-up of PR 9724. Stop including empty properties when copying object to the clipboard #11441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f50174
Stop including empty properties when copying object to the clipboard
lukaszgo1 Jul 30, 2020
1312a6e
Merge branch 'master' into I11438
michaelDCurran Aug 3, 2020
ea31636
Update what's new
michaelDCurran Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/globalCommands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,7 @@ def script_navigatorObject_current(self,gesture):
if curObject.TextInfo!=NVDAObjectTextInfo:
textList=[]
name = curObject.name
if isinstance(name, str) and not name.isspace():
if name and isinstance(name, str) and not name.isspace():
textList.append(name)
try:
info=curObject.makeTextInfo(textInfos.POSITION_SELECTION)
Expand All @@ -868,7 +868,7 @@ def script_navigatorObject_current(self,gesture):
else:
textList=[]
for prop in (curObject.name, curObject.value):
if isinstance(prop,str) and not prop.isspace():
if prop and isinstance(prop, str) and not prop.isspace():
textList.append(prop)
text=" ".join(textList)
if len(text)>0 and not text.isspace():
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ What's New in NVDA
- In Google chrome, NVDA will now report not checked for all checkable controls (not just check boxes) that are currently not checked. (#11377)
- It is once again possible to navigate in various controls when NVDA's language is set to Aragonese. (#11384)
- NVDA should no longer sometimes freeze in Microsoft Word when rapidly arrowing up and down or typing characters with Braille enabled. (#11431, #11425, #11414)
- NVDA no longer appends nonexistent trailing space when copying the current navigator object to the clipboard. (#11438)


== Changes For Developers ==
Expand Down