Skip to content

Fix keyCommandsDoc raises UnboundLocalError for a malformed settingsSection command #11309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelDCurran merged 1 commit into from
Jun 29, 2020
Merged

Fix keyCommandsDoc raises UnboundLocalError for a malformed settingsSection command #11309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions keyCommandsDoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,11 @@ def _command(self, cmd=None, arg=None):
# Each of the remaining columns provides keystrokes for one layout.
# There's one less delimiter than there are columns, hence subtracting 1 instead of 2.
self._settingsNumLayouts = arg.strip("|").count("|") - 1
if self._settingsNumLayouts < 1:
raise KeyCommandsError(
f"{self._lineNum}, settingsSection command must specify the header row for a table"
" summarising the settings"
)
elif cmd == "setting":
self._handleSetting()

Expand Down