Skip to content

Set Flake8 encoding to UTF-8 #11108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feerrenrut merged 2 commits into from
May 4, 2020
Merged

Set Flake8 encoding to UTF-8 #11108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
208eced
Set Flake8 encoding to UTF-8
JulienCochuyt May 4, 2020
3153c8d
Set Flake8 encoding to UTF-8 when invoked by AppVeyor
JulienCochuyt May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ test_script:
git diff -U0 FETCH_HEAD...HEAD > $prDiff
$flake8Config = "$lintSource\flake8.ini"
$flake8Output = "$lintOutput\PR-Flake8.txt"
type "$prDiff" | py -m flake8 --diff --output-file="$flake8Output" --tee --config="$flake8Config"
type "$prDiff" | py -Xutf8 -m flake8 --diff --output-file="$flake8Output" --tee --config="$flake8Config"
if($LastExitCode -ne 0) {
$errorCode=$LastExitCode
Add-AppveyorMessage "PR introduces Flake8 errors"
Expand Down
4 changes: 3 additions & 1 deletion tests/lint/sconscript
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ lintTarget = externalEnv.Command(
"current.diff",
[[
'type', '$SOURCE', '|', # provide diff to stdin
sys.executable, "-m", "flake8",
sys.executable,
"-Xutf8", # UTF-8 mode (PEP 540, Python >= 3.7)
Comment thread
JulienCochuyt marked this conversation as resolved.
"-m", "flake8",
'--diff', # accept a unified diff from stdin
'--output-file=$TARGET', # output to a file to allow easier inspection
'--tee', # also output to stdout, so results appear in scons output
Expand Down