Skip to content

Python 3: change remaining next method in objidl.IEnumMoniker - #10386

Merged
feerrenrut merged 1 commit into
nvaccess:masterfrom
BabbageCom:objIdl
Oct 15, 2019
Merged

Python 3: change remaining next method in objidl.IEnumMoniker#10386
feerrenrut merged 1 commit into
nvaccess:masterfrom
BabbageCom:objIdl

Conversation

@LeonarddeR

@LeonarddeR LeonarddeR commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

Link to issue number:

Slightly related to #9535

Summary of the issue:

objidl.IEnumMoniker is used as an iterable in the visual studio appModule. However, due to python 2/3 change (next method should be __next__), this part of the code did not work as expected.

Description of how this pull request fixes the issue:

Change next into __next__ as expected.

Testing performed:

Tested the following code snipped, based on the devenv appModule

ROT = objbase.GetRunningObjectTable()
list(ROT)

Known issues with pull request:

None

Change log entry:

None needed

@LeonarddeR LeonarddeR added this to the 2019.3 milestone Oct 15, 2019
@LeonarddeR
LeonarddeR requested a review from feerrenrut October 15, 2019 06:23
@feerrenrut feerrenrut added the z Python 3 transition (archived) Python 3 transition label Oct 15, 2019

@feerrenrut feerrenrut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LeonarddeR

@feerrenrut
feerrenrut merged commit 5bd8872 into nvaccess:master Oct 15, 2019
@LeonarddeR
LeonarddeR deleted the objIdl branch November 21, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants