-
-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse of more than three dots into "padding dots" symbol cannot be disabled #16345
Comments
CC @CyrilleB79. |
Note that previously, NVDA said "4 dots" on my end, not "dot dot dot dot".
I agree that "padding" is making an hypothesis on the usage of these dots, which is not true in all cases. If we rename the string to something more semantically neutral such as "multiple dots", would it be better for you? Or do you need to know the exact number of dots? In #16141 (comment), you explain the original use case which has triggered the opening of this issue:
Could you provide sample texts of these notifications or other cases where you have such dot sequence? Usual punctuation uses one or three dots, so all other cases are something more specific that should be exhibited here as concrete examples please. Thanks. |
To provide a special case, in Chinese the ellipsis is usually expressed as "......", but sometimes it is also expressed directly with six dots, for the example, "......". |
Note that ellipsis has a lot of ways to be expressed, chinese should not be honored here. Either we go all way and implement all ellipsis pronounciations in the symbol.dic files, or we let the users to interpret where an ellipsis should apply based on the context of the reading. Voice over can indeed count the symbols if there are more than x symbols next to each other. I am quite sure there must be a pythonic way to do this by traversing the string or so and counting the characters if they are the same, and it could be an optional setting in general settings category. For example, if more than 2 dots or dashes or underlines are next to each other, NVDA reports the number of these symbols instead of every of them. |
@codeofdusk instead of reverting the padding symbols all together, would it not be better to find a pythonic way of counting characters and revert it afterwards? I think there is still the possibility to hear all symbols if you change the symbol level, so the ellipsis thing is not really urgent to solve that fast. Or am I wrong? |
@codeofdusk, I can see that you have opened #16364. I am not against reverting #16345 if it causes issues. But in #16364, you are describing the Chinese use case as the reason to revert. But I seem to have understood that the "padding dots" modification was very annoying for you and that Chinese was not your main use case. |
@codeofdusk have you seen #16345 (comment)? More specifically, can you answer the following questions?
Thanks. |
Just to note, hash signs are already counted in NVDA if there are more than 3 signs consecutively, so maybe we can use that logic here as well. |
And also for dashes and underlines. |
@Adriani90 and all: It's clear that the expression "padding dots" is not suitable since it does not cover all use cases. I have proposed to replace it by "multiple dots". If only this change needs to be made, it is very easy to do it in the But if you (@codeofdusk, @Adriani90) or anyone else want to continue having the number of dots being reported, it cannot be managed only be a modification in |
@Adriani90 wrote:
By the way, isn't dash and underline characters repetition reported on your end? Provided you have the punctuation level high enough of course. |
Given that we report number of occurrences of each symbol other than dot, I'd say we should try to be consistent and do the same for dot. Are multiple dots in a row present in tables of content really as common, as to justify breaking the rule? Can this case be solved in a different way? |
So I tested now with NVDA 2023.3.4 again, and it seems indeed the number of dots were reported as expected when symbols were next to each other. Contrary to what I though that every single dot is reported. Sorry for not having tested this in more details.
Ideal behavior:
This would be more consistent with e.g. dashes and would still be good enough to solve #15845. |
@lukaszgo1 wrote:
Given that we report number of occurrences of each symbol other than dot
At least for me, multiple dots are already reported. If I place a line of periods in Notepad, I get "10 dot" (anything more than four dots), with punctuation level higher than None.
Generally I think I agree with @Adriani90's position.
At none or some punctuation level, multiple periods should just be pauses.
For three or six dots, we should report elipsis I think, at Most or all symbol level..
When reviewing by word, the current 2024.1 behavior should be preserved--report number of dots.
|
I disagree with this particular elipsis reporting. Elipsis can be expressed also via other sighn, not only dots. This should remain at interpretation of user whether it is contextually elipsis or not when reading. The number of dots is information enough to deduce the elipsis.
Did you mean 2023.4? In 2024.1 padding dots is reported, this should not be preserved, neither for word review. The number of dots should be reprted for word review as well. |
I wrote:
@Adriani90 responded:
No, I meant 2024.1. Padding dots is introduced in 2024.2 (so is unreleased) per the changelog, and also as easily tested with my copy of 2024.1RC1. |
Adding to 2024.2 milestone since it impact a new feature from this dev cycle. NV Access (@seanbudd or others), feel free to remove from the milestone if you decide it's not important. |
Related to #16345. Summary of the issue: Multiple dots are reported as "padding dots" in situations where these dots have no padding function. "padding" is too restrictive and is also more difficult to understand; by the way, some translators have actually translated "padding dots" to "multiple dots" in their translations. Description of user facing changes Multiple dots (4 or more) will now be reported with the more neutral "multiple dots" instead of "padding dots" when the symbol level is high enough. Description of development approach Changed both the symbol name and what is reported in symbol file.
Steps to reproduce:
Actual behavior:
NVDA says "padding dots".
Expected behavior:
NVDA says "dot dot dot dot". This behaviour changed in #16141, and the string "padding dots" is very confusing without the PR context. This collapsing should be disabled at the "all" symbol level (as all symbols aren't reported) or at very least user configurable even if enabled by default.
NVDA logs, crash dumps and other attachments:
N/A
System configuration
N/A
Other questions
N/A
Context
See #16141 (comment)
The text was updated successfully, but these errors were encountered: