Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to RAPIDS 24.10 #494

Merged
merged 22 commits into from
Oct 4, 2024
Merged

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Aug 28, 2024

Description

Closes #478
Requires nv-morpheus/utilities#75

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@cwharris cwharris added non-breaking Non-breaking change feature request New feature or request labels Aug 28, 2024
@cwharris cwharris marked this pull request as ready for review August 28, 2024 18:53
@cwharris cwharris requested review from a team as code owners August 28, 2024 18:53
cmake/dependencies.cmake Show resolved Hide resolved
cpp/mrc/src/internal/utils/contains.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

ci/conda/recipes/libmrc/conda_build_config.yaml Outdated Show resolved Hide resolved
@cwharris cwharris added the conda-build Enables running the conda-build step on a PR label Oct 4, 2024
@cwharris
Copy link
Contributor Author

cwharris commented Oct 4, 2024

/merge

@rapids-bot rapids-bot bot merged commit cef7f0b into nv-morpheus:branch-24.10 Oct 4, 2024
17 checks passed
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.95%. Comparing base (bceb7ef) to head (ca9a96a).
Report is 5 commits behind head on branch-24.10.

Files with missing lines Patch % Lines
python/mrc/_pymrc/src/logging.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.10     #494      +/-   ##
================================================
- Coverage         74.07%   73.95%   -0.13%     
================================================
  Files               403      403              
  Lines             14401    14430      +29     
  Branches           1132     1133       +1     
================================================
+ Hits              10668    10671       +3     
- Misses             3733     3759      +26     
Flag Coverage Δ
cpp 70.76% <0.00%> (-0.09%) ⬇️
py 41.81% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cpp/mrc/include/mrc/core/utils.hpp 45.16% <ø> (ø)
cpp/mrc/src/internal/utils/contains.hpp 100.00% <ø> (ø)
python/mrc/_pymrc/src/logging.cpp 68.75% <0.00%> (-2.22%) ⬇️

... and 32 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bceb7ef...ca9a96a. Read the comment docs.

rapids-bot bot pushed a commit to nv-morpheus/Morpheus that referenced this pull request Oct 9, 2024
Closes #1717
Requires nv-morpheus/utilities#75
Requires nv-morpheus/MRC#494

Issues opened during the course of this upgrade:
- #1925

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Christopher Harris (https://github.com/cwharris)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
  - Tad ZeMicheal (https://github.com/tzemicheal)

URL: #1874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda-build Enables running the conda-build step on a PR feature request New feature or request non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA]: Upgrade to RAPIDS 24.10
4 participants