Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying cmake exports name across all Morpheus repos #427

Merged

Conversation

mdemoret-nv
Copy link
Contributor

@mdemoret-nv mdemoret-nv commented Dec 22, 2023

This PR fixes an issue where some libraries were using ${PROJECT_NAME}-core-exports and others were using ${PROJECT_NAME}-exports. Since there is no need for multiple export sets anymore, this updates all exports to be ${PROJECT_NAME}-exports

Requires nv-morpheus/utilities#61 to be merged first

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change conda-build Enables running the conda-build step on a PR labels Dec 22, 2023
@mdemoret-nv mdemoret-nv requested review from a team as code owners December 22, 2023 21:34
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Merging #427 (9d14707) into branch-24.03 (294e087) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.03     #427      +/-   ##
================================================
+ Coverage         74.00%   74.03%   +0.03%     
================================================
  Files               394      394              
  Lines             13955    13955              
  Branches           1053     1053              
================================================
+ Hits              10327    10332       +5     
+ Misses             3628     3623       -5     
Flag Coverage Δ
cpp 70.50% <ø> (+0.02%) ⬆️
py 42.62% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 294e087...9d14707. Read the comment docs.

@dagardner-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 75e43dd into nv-morpheus:branch-24.03 Jan 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conda-build Enables running the conda-build step on a PR non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants