Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for MRC/Morpheus to build in the same RAPIDS devcontainer environment #375

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Sep 4, 2023

Adds a new dependencies.yaml which is used in RAPIDS devcontainer utils to generate conda env yamls, project.toml's, and setup.pys on-the-fly using https://github.com/rapidsai/dependency-file-generator. Eventually we can generate/verify our existing environment files this way, but for now this gets us up and running in a RAPIDS devcontainer.

Also changes prometheus-cpp::core to a PRIVATEly linked library, as it's not longer necessary to be PUBLIC, and otherwise breaks a combined MRC/Morpheus build.

Also adds a MRC_PYTHON_INPLACE_BUILD cmake option, which enables pybind11 modules to be copied back to the source tree.

MRC/Morpheus unified build environment is a WIP, but available here: https://github.com/cwharris/cyber-dev.

Contributes to nv-morpheus/Morpheus#704

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@cwharris cwharris requested review from a team as code owners September 4, 2023 19:07
@cwharris cwharris added non-breaking Non-breaking change feature request New feature or request labels Sep 4, 2023
CMakeLists.txt Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #375 (d6ef130) into branch-23.11 (a2a9829) will increase coverage by 21.88%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           branch-23.11     #375       +/-   ##
=================================================
+ Coverage         51.20%   73.09%   +21.88%     
=================================================
  Files               346      382       +36     
  Lines             11041    13404     +2363     
  Branches            930     1010       +80     
=================================================
+ Hits               5654     9797     +4143     
+ Misses             5387     3607     -1780     
Flag Coverage Δ
cpp 69.01% <ø> (+26.04%) ⬆️
py 42.06% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 163 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a9829...d6ef130. Read the comment docs.

@cwharris
Copy link
Contributor Author

cwharris commented Sep 7, 2023

/merge

@rapids-bot rapids-bot bot merged commit 79a27e2 into nv-morpheus:branch-23.11 Sep 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants