Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing actions running on non-PR branches #354

Merged

Conversation

mdemoret-nv
Copy link
Contributor

Description

Actions running after a PR is merged are broken due to the Prepare step assuming there is a PR. This fixes the prepare step to work with and without a PR

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Jul 13, 2023
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner July 13, 2023 17:58
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #354 (46193ac) into branch-23.07 (7345aa6) will increase coverage by 21.91%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           branch-23.07     #354       +/-   ##
=================================================
+ Coverage         51.20%   73.12%   +21.91%     
=================================================
  Files               346      382       +36     
  Lines             11041    13403     +2362     
  Branches            930     1010       +80     
=================================================
+ Hits               5654     9801     +4147     
+ Misses             5387     3602     -1785     
Flag Coverage Δ
cpp 69.06% <ø> (+26.09%) ⬆️
py 42.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 163 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7345aa6...46193ac. Read the comment docs.

@mdemoret-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f6053ed into nv-morpheus:branch-23.07 Jul 13, 2023
@mdemoret-nv mdemoret-nv deleted the mdd_fix-branch-actions branch July 13, 2023 21:51
dagardner-nv added a commit to dagardner-nv/MRC that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants