Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround GCC 11.3 compiler bug #339

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

mdemoret-nv
Copy link
Contributor

Description

Compiling on GCC 11.3 breaks due to this compiler bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103871. Using the workaround in this comment seems to fix the issue.

Tested on 11.3 locally. Changes should be benign. No way to test this in CI without adding GCC 11.3 to the build matrix.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Jun 30, 2023
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner June 30, 2023 00:22
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #339 (cfad09b) into branch-23.07 (37a3c36) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.07     #339      +/-   ##
================================================
+ Coverage         73.10%   73.13%   +0.02%     
================================================
  Files               382      382              
  Lines             13404    13404              
  Branches           1011     1010       -1     
================================================
+ Hits               9799     9803       +4     
+ Misses             3605     3601       -4     
Flag Coverage Δ
cpp 69.07% <100.00%> (+0.03%) ⬆️
py 42.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/include/mrc/coroutines/ring_buffer.hpp 90.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37a3c36...cfad09b. Read the comment docs.

@dagardner-nv dagardner-nv self-requested a review June 30, 2023 19:24
@mdemoret-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d96910b into nv-morpheus:branch-23.07 Jun 30, 2023
@mdemoret-nv mdemoret-nv deleted the mdd_fix-gcc-11.3 branch July 5, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants