Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove boost::filesystem #334

Merged

Conversation

mdemoret-nv
Copy link
Contributor

Description

This PR removes all references to boost::filesystem in favor of std::filesystem. The std library should be preferred over the boost version

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mdemoret-nv mdemoret-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels Jun 21, 2023
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner June 21, 2023 18:48
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #334 (b970681) into branch-23.07 (0d0ab70) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-23.07     #334   +/-   ##
=============================================
  Coverage         73.29%   73.29%           
=============================================
  Files               390      390           
  Lines             13382    13382           
  Branches           1009     1010    +1     
=============================================
  Hits               9809     9809           
  Misses             3573     3573           
Flag Coverage Δ
cpp 69.26% <ø> (ø)
py 42.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/src/public/modules/plugins.cpp 54.26% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d0ab70...b970681. Read the comment docs.

@mdemoret-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fea298f into nv-morpheus:branch-23.07 Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants