Use AWS OIDC to get AWS creds #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjacobelli
added
improvement
Signed-off-by: Jordan Jacobelli <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.03 #294 +/- ##
=============================================
Coverage 72.95% 72.95%
=============================================
Files 381 381
Lines 13117 13117
Branches 992 991 -1
=============================================
Hits 9569 9569
Misses 3548 3548
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ajschmidt8
approved these changes
Mar 7, 2023
dagardner-nv
approved these changes
Mar 7, 2023
|
/merge |
ajschmidt8
added a commit
to ajschmidt8/MRC
that referenced
this pull request
Mar 8, 2023
This PR is a continuation of nv-morpheus#294. Omitting the other keys in the `permissions` block sets them to `none` ([src](https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#overview)). This is probably not a concern for `nv-morpheus`, but it caused issues for some private RAPIDS repositories so I wanted to update the `nv-morpheus` repos for consistency. To remedy this, this PR includes the following changes: - Keeps the `id-token` permission as `write`, but sets the remaining permissions as described in the `restricted` column [here](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token) - Also sets `pull_request` to `read` so that `fetch_base_branch` in `common.sh` can use it - Moves the `permissions` blocks to the top of the workflows to DRY them up
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 8, 2023
This PR is a continuation of #294. Omitting the other keys in the `permissions` block sets them to `none` ([src](https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs#overview)). This is probably not a concern for `nv-morpheus`, but it caused issues for some private RAPIDS repositories so I wanted to update the `nv-morpheus` repos for consistency. To remedy this, this PR includes the following changes: - Keeps the `id-token` permission as `write`, but sets the remaining permissions as described in the `restricted` column [here](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token) - Also sets `pull_request` to `read` so that `fetch_base_branch` in `common.sh` can use it - Moves the `permissions` blocks to the top of the workflows to DRY them up Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is using the AWS OIDC to get AWS credentials (doc). Currently we are using permanent tokens that we need to manually rotate every 90 days. This PR is removing this requirement.
The
AWS_ROLE_ARNandAWS_REGIONare orgs variables defined here: https://github.com/organizations/nv-morpheus/settings/variables/actions.