Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sccache bucket #289

Merged
4 commits merged into from
Feb 14, 2023
Merged

Update sccache bucket #289

4 commits merged into from
Feb 14, 2023

Conversation

ajschmidt8
Copy link
Contributor

This PR updates the sccache configuration settings to use a new bucket, rapids-sccache-east.

Unlike the previous rapids-sccache bucket, rapids-sccache-east resides in the same AWS region as the rest of our CI infrastructure (us-east-2).

This should result in faster, more reliable sccache connections and will also help keep our data transfer costs down.

Important Note: The changes from this sccache PR are required to use a bucket in us-east-2. These changes were incorporated in sccache v0.3.2, so you'll need that version or later (preferably the latest, v0.3.3). Please ensure that your CI images satisfy this constraint before merging this PR.

Additionally, this PR updates the SCCACHE_REGION to the region of the bucket. This value is not meant to be a variable.

This PR updates the `sccache` configuration settings to use a new bucket, `rapids-sccache-east`.

Unlike the previous `rapids-sccache` bucket, `rapids-sccache-east` resides in the same AWS region as the rest of our CI infrastructure (`us-east-2`).

This should result in faster, more reliable `sccache` connections and will also help keep our data transfer costs down.

**Important Note**: The changes from [this `sccache` PR](mozilla/sccache#1403) are required to use a bucket in `us-east-2`. These changes were incorporated in `sccache` `v0.3.2`, so you'll need that version or later (preferably the latest, `v0.3.3`). Please ensure that your CI images satisfy this constraint before merging this PR.

Additionally, this PR updates the `SCCACHE_REGION` to the region of the bucket. This value is not meant to be a variable.
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner February 12, 2023 00:01
@ajschmidt8 ajschmidt8 added improvement Improvement to existing functionality non-breaking Non-breaking change labels Feb 12, 2023
Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we're still on sccache 0.3.1, will need to push up new images this morning.

@dagardner-nv
Copy link
Contributor

#290

Adopt updated CI runner with sccache 0.3.3
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #289 (24e2b17) into branch-23.03 (e170431) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-23.03     #289   +/-   ##
=============================================
  Coverage         72.95%   72.95%           
=============================================
  Files               381      381           
  Lines             13117    13117           
  Branches            993      992    -1     
=============================================
  Hits               9569     9569           
  Misses             3548     3548           
Flag Coverage Δ
cpp 68.70% <ø> (+<0.01%) ⬆️
py 41.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e170431...24e2b17. Read the comment docs.

@dagardner-nv dagardner-nv self-requested a review February 14, 2023 15:55
@dagardner-nv
Copy link
Contributor

/merge

@ghost ghost merged commit 7a6ea6a into branch-23.03 Feb 14, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants