Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror module / buffer + python bindings. #286

Merged
merged 71 commits into from
Mar 24, 2023

Conversation

drobison00
Copy link
Contributor

@drobison00 drobison00 commented Feb 3, 2023

Closes #126

…g on reducing the cognative load associated with Mirror Taps
@drobison00 drobison00 changed the title [DRAFT] Mirror module / buffer + python bindings. Mirror module / buffer + python bindings. Mar 15, 2023
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes that we discussed earlier about relocating files. Still looking into a few of the tap ring buffer implementations.

cpp/mrc/include/mrc/edge/edge_builder.hpp Outdated Show resolved Hide resolved
cpp/mrc/include/mrc/edge/edge_builder.hpp Outdated Show resolved Hide resolved
cpp/mrc/include/mrc/modules/mirror_tap/mirror_tap_util.hpp Outdated Show resolved Hide resolved
cpp/mrc/include/mrc/modules/sample_modules.hpp Outdated Show resolved Hide resolved
cpp/mrc/tests/test_edges.cpp Outdated Show resolved Hide resolved
python/mrc/_pymrc/include/pymrc/segment.hpp Outdated Show resolved Hide resolved
cpp/mrc/include/mrc/edge/edge_builder.hpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #286 (ba5f55d) into branch-23.03 (d0c9ae6) will increase coverage by 0.38%.
The diff coverage is 87.44%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.03     #286      +/-   ##
================================================
+ Coverage         72.92%   73.30%   +0.38%     
================================================
  Files               381      390       +9     
  Lines             13118    13353     +235     
  Branches            991     1006      +15     
================================================
+ Hits               9566     9789     +223     
- Misses             3552     3564      +12     
Flag Coverage Δ
cpp 69.13% <75.88%> (+0.45%) ⬆️
py 42.21% <84.89%> (+1.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/include/mrc/modules/segment_modules.hpp 100.00% <ø> (ø)
cpp/mrc/include/mrc/node/operators/broadcast.hpp 87.09% <ø> (-4.43%) ⬇️
cpp/mrc/include/mrc/segment/object.hpp 51.45% <ø> (+9.40%) ⬆️
cpp/mrc/src/public/segment/definition.cpp 100.00% <ø> (ø)
cpp/mrc/src/tests/pipelines/multi_segment.cpp 100.00% <ø> (ø)
cpp/mrc/src/tests/segments/common_segments.cpp 100.00% <ø> (ø)
cpp/mrc/src/tests/test_next.cpp 87.80% <ø> (ø)
cpp/mrc/src/tests/test_pipeline.cpp 97.23% <ø> (ø)
python/mrc/_pymrc/include/pymrc/segment.hpp 90.90% <0.00%> (-9.10%) ⬇️
python/mrc/_pymrc/src/py_segment_module.cpp 75.00% <ø> (ø)
... and 28 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c9ae6...ba5f55d. Read the comment docs.

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good now.

@mdemoret-nv mdemoret-nv dismissed ryanolson’s stale review March 24, 2023 15:49

Dismissing to allow merging for release. Reviewed by mdemoret-nv

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit a7a2d1d into nv-morpheus:branch-23.03 Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA] Add supporting infrastructure and primitives for Morpheus training pipelines.
3 participants