Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing TL Expected #278

Merged
1 commit merged into from
Jan 28, 2023

Conversation

mdemoret-nv
Copy link
Contributor

TL Expected, while not used, is still in the dependency list and this breaks conda packages.

@mdemoret-nv mdemoret-nv requested a review from a team as a code owner January 28, 2023 01:05
@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Jan 28, 2023
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #278 (69a709f) into branch-23.01 (f1a1132) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.01     #278      +/-   ##
================================================
+ Coverage         72.89%   72.92%   +0.03%     
================================================
  Files               381      381              
  Lines             13103    13103              
  Branches            991      991              
================================================
+ Hits               9552     9556       +4     
+ Misses             3551     3547       -4     
Flag Coverage Δ
cpp 68.72% <ø> (+0.04%) ⬆️
py 40.92% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/src/internal/system/partitions.cpp 78.94% <0.00%> (+0.75%) ⬆️
cpp/mrc/src/internal/resources/manager.cpp 91.91% <0.00%> (+1.01%) ⬆️
cpp/mrc/src/internal/memory/host_resources.cpp 74.28% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1a1132...69a709f. Read the comment docs.

@mdemoret-nv
Copy link
Contributor Author

/merge

@ghost ghost merged commit f526aff into nv-morpheus:branch-23.01 Jan 28, 2023
@mdemoret-nv mdemoret-nv deleted the mdd_remove-tl-expected branch January 28, 2023 01:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants