Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Concepts #262

Merged
4 commits merged into from
Jan 13, 2023
Merged

Core Concepts #262

4 commits merged into from
Jan 13, 2023

Conversation

ryanolson
Copy link
Contributor

The most general concepts will be located in mrc/core/concepts.

This PR added core::concepts::not_void which will be used quite broadly. It's first use will be in channels::v2 as we never have a channel with a data type of void.

@ryanolson ryanolson added improvement Improvement to existing functionality non-breaking Non-breaking change labels Dec 27, 2022
@ryanolson ryanolson requested a review from a team as a code owner December 27, 2022 04:37
@codecov
Copy link

codecov bot commented Dec 27, 2022

Codecov Report

Merging #262 (d053eeb) into branch-23.01 (0151a7a) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.01     #262      +/-   ##
================================================
- Coverage         72.52%   72.47%   -0.05%     
================================================
  Files               376      376              
  Lines             12082    12082              
  Branches            921      921              
================================================
- Hits               8762     8757       -5     
- Misses             3320     3325       +5     
Flag Coverage Δ
cpp 69.31% <ø> (-0.05%) ⬇️
py 38.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/src/internal/memory/host_resources.cpp 65.62% <0.00%> (-6.25%) ⬇️
cpp/mrc/src/public/coroutines/thread_pool.cpp 90.32% <0.00%> (-1.62%) ⬇️
cpp/mrc/src/internal/resources/manager.cpp 90.62% <0.00%> (-1.05%) ⬇️
cpp/mrc/src/internal/system/partitions.cpp 78.19% <0.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0151a7a...d053eeb. Read the comment docs.

@ryanolson ryanolson mentioned this pull request Dec 27, 2022
1 task
@mdemoret-nv
Copy link
Contributor

/merge

@ghost ghost merged commit 7439865 into nv-morpheus:branch-23.01 Jan 13, 2023
@dagardner-nv dagardner-nv mentioned this pull request Aug 18, 2023
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Aug 18, 2023
* Adopt patched pybind11
* Update versions of boost & libhwloc to work-around clang CI issue
* A test for this bug exists in Morpheus, but is difficult to reproduce in MRC. A MRC based test coming soon.

fixes #262

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #364
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants