-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRC changes related to utility consolidation #241
Conversation
Should this be a draft pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but it looks like there are a few things that shouldnt be in there regarding tracers
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.01 #241 +/- ##
================================================
- Coverage 72.47% 72.46% -0.01%
================================================
Files 376 375 -1
Lines 12340 12339 -1
Branches 921 922 +1
================================================
- Hits 8943 8942 -1
Misses 3397 3397
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
Depends on: https://github.com/nv-morpheus/utilities/pull/1/files#diff-9a3c07061febeba4d3e5191e87706e262644abf8514317eeb084e67137e7c807
Shifts to using a shared utilities submodule for shared cmake, scripts, utilities, etc.. This shared repo provides a number of new morpheus_utils_xxx cmake macros/functions that are now used throughout the configuration process.