Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRC changes related to utility consolidation #241

Merged
58 commits merged into from
Jan 14, 2023

Conversation

drobison00
Copy link
Contributor

@drobison00 drobison00 commented Dec 2, 2022

Depends on: https://github.com/nv-morpheus/utilities/pull/1/files#diff-9a3c07061febeba4d3e5191e87706e262644abf8514317eeb084e67137e7c807

Shifts to using a shared utilities submodule for shared cmake, scripts, utilities, etc.. This shared repo provides a number of new morpheus_utils_xxx cmake macros/functions that are now used throughout the configuration process.

@drobison00 drobison00 added improvement Improvement to existing functionality non-breaking Non-breaking change DO NOT MERGE labels Dec 2, 2022
@drobison00 drobison00 requested review from a team as code owners December 2, 2022 22:08
@drobison00 drobison00 self-assigned this Dec 2, 2022
@drobison00 drobison00 requested a review from a team as a code owner December 2, 2022 22:08
@cwharris
Copy link
Contributor

cwharris commented Dec 2, 2022

Should this be a draft pr?

@ryanolson ryanolson marked this pull request as draft December 4, 2022 05:36
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@drobison00 drobison00 added this to the 23.01 Refactor milestone Jan 12, 2023
@drobison00 drobison00 marked this pull request as ready for review January 12, 2023 18:55
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but it looks like there are a few things that shouldnt be in there regarding tracers

.gitmodules Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
ci/scripts/github/checks.sh Outdated Show resolved Hide resolved
python/mrc/_pymrc/src/tracers.cpp Outdated Show resolved Hide resolved
python/mrc/benchmarking/CMakeLists.txt Outdated Show resolved Hide resolved
python/mrc/benchmarking/__init__.py Show resolved Hide resolved
python/mrc/benchmarking/watchers.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Merging #241 (e83397e) into branch-23.01 (57abd43) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.01     #241      +/-   ##
================================================
- Coverage         72.47%   72.46%   -0.01%     
================================================
  Files               376      375       -1     
  Lines             12340    12339       -1     
  Branches            921      922       +1     
================================================
- Hits               8943     8942       -1     
  Misses             3397     3397              
Flag Coverage Δ
cpp 69.46% <0.00%> (ø)
py 38.10% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/src/public/utils/type_utils.cpp 31.66% <0.00%> (ø)
python/mrc/benchmarking/watchers.cpp 83.33% <88.88%> (+0.87%) ⬆️
python/mrc/benchmarking/tracers.cpp

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57abd43...e83397e. Read the comment docs.

@drobison00
Copy link
Contributor Author

/merge

@ghost ghost merged commit 9dc7cb2 into nv-morpheus:branch-23.01 Jan 14, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants