Development container image

[ryanolson]

Resolves #203

[mdemoret-nv]

One issue with deleting the old Dockerfile and using this as the new dev container, the instructions for building conda packages are now out of date. The old instructions had the user build the dev container and then run a script. This doesnt work anymore since the Dockerfile has been removed. We can use the new dev container from this PR to build the conda images with a couple of tweaks. This PR should update those instructions so they work again. Instructions are here: https://github.com/nv-morpheus/MRC/blob/branch-23.01/ci/conda/README.md.

I think the easiest solution is to just make a single Dockerfile with a targets for base, driver, and development. Doing it this way has a few advantages:

1. You wont have to have the yq script look at the yaml file for the base image. It can just build it from earlier stages
2. External users who dont have NGC setup can still build development containers
3. We can use the same Dockerfile for building, testing, development, and building conda packages.

[ryanolson]

This makes sense. Seems like we should have 4 targets with the additional two being for conda packaging and one for development.

[cwharris]

@mdemoret-nv

We can use the same Dockerfile for building, testing, development, and building conda packages.

What's the advantage to this? It creates one large confusing Dockerfile, leads to oversized images, and doesn't give us the chance to create a fast-building dev image.

[ryanolson]

@mdemoret-nv

We can use the same Dockerfile for building, testing, development, and building conda packages.

What's the advantage to this? It creates one large confusing Dockerfile, leads to oversized images, and doesn't give us the chance to create a fast-building dev image.

I'll add the option to skip the conda install if an ENV is set when VS code evaluates the devcontainer or when devel.sh is called.

I'd propose MRC_LOCAL_CONDA_ENV.

This can be a separate PR since I'd like to get the devcontainer kn main so that path is generally persistent across branches. If I'm in a branch without, which is all the other branches right now, then if I have to reload vs code, I have to swap bsck to the dev_image branch to successfully reload.

[cwharris]

I'll add the option to skip the conda install if an ENV is set when VS code evaluates the devcontainer or when devel.sh is called.

What problem does this solve?

[mdemoret-nv]

Two small changes

[codecov]

Codecov Report

Base: 0.23% // Head: 0.23% // No change to project coverage 👍

Coverage data is based on head (49612c3) compared to base (6e97e7f).
Patch has no changes to coverable lines.

Additional details and impacted files

@@             Coverage Diff              @@
##           branch-23.01    #236   +/-   ##
============================================
  Coverage          0.23%   0.23%           
============================================
  Files               349     349           
  Lines              9898    9898           
  Branches           4807    4807           
============================================
  Hits                 23      23           
  Misses             9875    9875           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ryanolson]

@gpucibot merge

all have been addressed

[ryanolson]

@gpucibot merge