Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing functionality to allow dynamic modules to forward their configuration to nested children. #224

Merged
4 commits merged into from
Nov 28, 2022

Conversation

drobison00
Copy link
Contributor

@drobison00 drobison00 commented Nov 28, 2022

Adds missing functionality to allow dynamic modules to forward their configuration to nested children.

Closes #223

@drobison00 drobison00 added improvement Improvement to existing functionality non-breaking Non-breaking change review: ready labels Nov 28, 2022
@drobison00 drobison00 requested review from a team as code owners November 28, 2022 22:38
@drobison00 drobison00 changed the title Resolves #223 Adds missing functionality to allow dynamic modules to forward their configuration to nested children. Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 32.60% // Head: 32.61% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (42b3b61) compared to base (da29e46).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.01     #224      +/-   ##
================================================
+ Coverage         32.60%   32.61%   +0.01%     
================================================
  Files               322      322              
  Lines              9095     9107      +12     
  Branches           4242     4251       +9     
================================================
+ Hits               2965     2970       +5     
+ Misses             3813     3810       -3     
- Partials           2317     2327      +10     
Impacted Files Coverage Δ
include/srf/segment/builder.hpp 44.64% <ø> (ø)
python/srf/_pysrf/include/pysrf/segment.hpp 69.23% <ø> (ø)
python/srf/core/segment.cpp 14.81% <0.00%> (-0.19%) ⬇️
src/public/segment/builder.cpp 41.42% <25.00%> (-2.12%) ⬇️
python/srf/_pysrf/src/segment.cpp 31.81% <33.33%> (+0.04%) ⬆️
src/internal/resources/manager.cpp 28.39% <0.00%> (ø)
src/internal/memory/host_resources.cpp 21.42% <0.00%> (ø)
src/internal/system/topology.cpp 27.68% <0.00%> (+0.56%) ⬆️
src/internal/system/partitions.cpp 22.97% <0.00%> (+0.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@drobison00
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit b4c7bd7 into nv-morpheus:branch-23.01 Nov 28, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA]: Add the ability to get the current module's config file when initializing a python defined module.
2 participants