Fix throwing errors from Executor.join_async()
#208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 37.96% // Head: 38.55% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.11 #208 +/- ##
================================================
+ Coverage 37.96% 38.55% +0.59%
================================================
Files 101 101
Lines 2439 2443 +4
Branches 1144 1145 +1
================================================
+ Hits 926 942 +16
+ Misses 716 694 -22
- Partials 797 807 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
drobison00
approved these changes
Nov 4, 2022
|
@gpucibot merge |
ghost
merged commit
ghost
pushed a commit
to nv-morpheus/Morpheus
that referenced
this pull request
Nov 18, 2022
This PR was some outstanding work that was a result of changes in the SRF PR: nv-morpheus/MRC#208. If an exception is detected, we can try to manually call stop on all stages to allow for better shutdown behavior. Included in this PR are fixes to remove `CMAKE_BUILD_RPATH_USE_ORIGIN` from the CMake file which breaks building SRF with Morpheus at the same time. This option is only needed during the CI build so it was added manually to the CI scripts. Authors: - Michael Demoret (https://github.com/mdemoret-nv) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #478
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions from both python and C++ were getting printed to the log but not raised in python when using
Executor.join_async(). This boils down to the fact thatfuture::wait()was called instead offuture::get()which actually rethrows the exception.Added some tests to check this functionality