-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dockerfile for CI runners #199
Conversation
… along with a readme
Codecov ReportBase: 37.96% // Head: 30.92% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.11 #199 +/- ##
================================================
- Coverage 37.96% 30.92% -7.04%
================================================
Files 101 309 +208
Lines 2439 8423 +5984
Branches 1144 3889 +2745
================================================
+ Hits 926 2605 +1679
- Misses 716 3799 +3083
- Partials 797 2019 +1222
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@dagardner-nv Do you know why the code coverage dropped so significantly with this PR? |
I don't know, that confuses me as well My guess is its a function of what is being transferred: Previously we transferred 5 different tars:
In the changes now transfer:
I suspect coverage is going down because the coverage tool just has a larger picture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving these changes now and we will look into the coverage issues in issue #211
@gpucibot merge |
Builds two images a
srf-ci
image and asrf-ci-driver
variant.Image sizes are 6GB and 6.1GB respectively (current image being used in CI is 14GB)
CI usage drops from around an hour and a half (https://github.com/nv-morpheus/SRF/actions/runs/3357911701/usage) down to about 40 minutes (https://github.com/nv-morpheus/SRF/actions/runs/3372276756)
Image contains:
fixes #185