Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile for CI runners #199

Merged
94 commits merged into from
Nov 17, 2022
Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 20, 2022

Builds two images a srf-ci image and a srf-ci-driver variant.
Image sizes are 6GB and 6.1GB respectively (current image being used in CI is 14GB)

CI usage drops from around an hour and a half (https://github.com/nv-morpheus/SRF/actions/runs/3357911701/usage) down to about 40 minutes (https://github.com/nv-morpheus/SRF/actions/runs/3372276756)

Image contains:

  • Pre-populated conda env
  • IWYU
  • Nvidia libs needed to build

fixes #185

@dagardner-nv dagardner-nv changed the title Add dockerfile for CI runner Add dockerfile for CI runners Nov 1, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 37.96% // Head: 30.92% // Decreases project coverage by -7.03% ⚠️

Coverage data is based on head (169f9f9) compared to base (827ff38).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.11     #199      +/-   ##
================================================
- Coverage         37.96%   30.92%   -7.04%     
================================================
  Files               101      309     +208     
  Lines              2439     8423    +5984     
  Branches           1144     3889    +2745     
================================================
+ Hits                926     2605    +1679     
- Misses              716     3799    +3083     
- Partials            797     2019    +1222     
Impacted Files Coverage Δ
include/srf/runnable/launch_options.hpp 25.00% <0.00%> (-75.00%) ⬇️
include/srf/node/edge_properties.hpp 50.00% <0.00%> (-50.00%) ⬇️
include/srf/node/edge_builder.hpp 47.82% <0.00%> (-30.75%) ⬇️
include/srf/runnable/runner.hpp 50.00% <0.00%> (-30.00%) ⬇️
include/srf/node/source_properties.hpp 70.00% <0.00%> (-30.00%) ⬇️
include/srf/core/task_queue.hpp 57.14% <0.00%> (-26.20%) ⬇️
include/srf/node/operators/operator.hpp 68.75% <0.00%> (-18.75%) ⬇️
include/srf/segment/object.hpp 40.00% <0.00%> (-17.15%) ⬇️
include/srf/node/sink_properties.hpp 75.00% <0.00%> (-15.00%) ⬇️
include/srf/pipeline/pipeline.hpp 46.15% <0.00%> (-14.96%) ⬇️
... and 232 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdemoret-nv
Copy link
Contributor

@dagardner-nv Do you know why the code coverage dropped so significantly with this PR?

@dagardner-nv
Copy link
Contributor Author

@dagardner-nv Do you know why the code coverage dropped so significantly with this PR?

I don't know, that confuses me as well

My guess is its a function of what is being transferred:
https://github.com/nv-morpheus/SRF/pull/199/files#diff-603c96c1c815fd43de92de0a8934c23b535603fee14336d4ffae960a274ec493L81

Previously we transferred 5 different tars:

  1. The coonda env
  2. Everything with a *.x extension
  3. Everything with a *.so extension
  4. The build/python dir
  5. Then for the coverage test we also take a tar of the .cache dir

In the changes now transfer:

  1. The entire build dir
  2. The .cache dir

I suspect coverage is going down because the coverage tool just has a larger picture.

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving these changes now and we will look into the coverage issues in issue #211

@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit be89623 into nv-morpheus:branch-22.11 Nov 17, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA] Create a new base image for rapids ci
3 participants