Skip to content

[AutoDeploy] no need for cleanup in ADExecutor - #15

Merged
lucaslie merged 1 commit into
feat/ad_coverage_week1from
ll/clean_dist_clean_up
May 20, 2025
Merged

[AutoDeploy] no need for cleanup in ADExecutor#15
lucaslie merged 1 commit into
feat/ad_coverage_week1from
ll/clean_dist_clean_up

Conversation

@lucaslie

@lucaslie lucaslie commented May 20, 2025

Copy link
Copy Markdown

see title

@lucaslie
[AutoDeploy] no need for cleanup in ADExecutor
3161a89 
Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 20, 2025 19:17
Copilot AI reviewed May 20, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unnecessary cleanup logic in the ADExecutor by eliminating the del method that called dist.cleanup().

  • Removed del method in ad_executor.py
  • Simplified resource management in the AutoDeploy executor

@lucaslie
lucaslie enabled auto-merge (squash) May 20, 2025 19:17
@lucaslie
lucaslie merged commit 799245f into feat/ad_coverage_week1 May 20, 2025
lucaslie added a commit that referenced this pull request May 27, 2025
@lucaslie
[AutoDeploy] no need for cleanup in ADExecutor (#15)
d2efbcb 
Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lucaslie