Skip to content

Conversation

@lucaslie
Copy link
Collaborator

see title

Signed-off-by: Lucas Liebenwein <[email protected]>
@lucaslie lucaslie self-assigned this Sep 26, 2025
Copilot AI review requested due to automatic review settings September 26, 2025 21:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an overflow calculation issue in the attention interface's sequence page allocation logic. The change corrects how the number of pages is computed when sequences require additional pages beyond the basic allocation.

  • Modified the overflow check calculation to use per-sequence token allocation instead of total tokens
  • Updated the comment to better explain the overflow detection logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lucaslie lucaslie merged commit bc267de into feat/ad_linear_attention Sep 26, 2025
2 of 3 checks passed
@lucaslie lucaslie deleted the ll/correct_page_overflow branch September 26, 2025 22:04
lucaslie added a commit that referenced this pull request Sep 29, 2025
nvchenghaoz pushed a commit that referenced this pull request Oct 1, 2025
nvchenghaoz pushed a commit that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants