Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useLocale): update locale import to enable tree shaking #2735

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

AnOrdinaryPeople
Copy link
Contributor

πŸ”— Linked issue

Resolves #2734

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The proposed change modifies the import to directly reference the required locale.

Final bundle from import { en } from '../locale' (before):
before

Final bundle from import en from '../locale/en' (after):
after

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

pkg-pr-new bot commented Nov 22, 2024

pnpm add https://pkg.pr.new/@nuxt/ui@2735

commit: 7397e34

@benjamincanac benjamincanac merged commit 3bccb67 into nuxt:v3 Nov 22, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants