Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(InputMenu/SelectMenu): add support for dot notation in by prop #2607

Merged
merged 3 commits into from
Nov 13, 2024
Merged

feat(InputMenu/SelectMenu): add support for dot notation in by prop #2607

merged 3 commits into from
Nov 13, 2024

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Nov 12, 2024 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Enhanced the prop by to support dot notation and resolved an issue where labels were not displaying correctly in the SelectMenu component when using both multiple and valueAttribute props

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar
feat(SelectMenu/InputMenu): add handle dot notation in prop by & fix …
1106cda 
…issue label does not show when prop multiple & valueAttribute used in component (SelectMenu)
@rdjanuar rdjanuar changed the title feat(SelectMenu/InputMenu): add handle dot notation in prop by feat(SelectMenu/InputMenu): handle dot notation on prop by Nov 12, 2024
@rdjanuar rdjanuar changed the title feat(SelectMenu/InputMenu): handle dot notation on prop by feat(SelectMenu/InputMenu): add support for dot notation in 'by' prop Nov 12, 2024
@rdjanuar rdjanuar changed the title feat(SelectMenu/InputMenu): add support for dot notation in 'by' prop feat(SelectMenu/InputMenu): add support for dot notation in by prop Nov 12, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 12, 2024 •
edited
Loading

Deploying ui3 with  Cloudflare Pages  Cloudflare Pages

Latest commit: bebd014
Status:🚫  Build failed.

View logs

@rdjanuar rdjanuar marked this pull request as draft November 12, 2024 10:04
@rdjanuar rdjanuar marked this pull request as ready for review November 12, 2024 10:10
@rdjanuar rdjanuar changed the title feat(SelectMenu/InputMenu): add support for dot notation in by prop feat(SelectMenu/InputMenu): add support for dot notation in by prop Nov 13, 2024
@benjamincanac benjamincanac changed the title feat(SelectMenu/InputMenu): add support for dot notation in by prop feat(InputMenu/SelectMenu): add support for dot notation in by prop Nov 13, 2024
@benjamincanac benjamincanac merged commit 53df9d9 into dev Nov 13, 2024
2 of 3 checks passed
@benjamincanac benjamincanac deleted the feat/handle-dot-notation-by-prop branch November 13, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdjanuar @benjamincanac