Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): improve expanded row #2485

Merged
merged 34 commits into from
Nov 5, 2024
Merged

feat(Table): improve expanded row #2485

merged 34 commits into from
Nov 5, 2024

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Oct 29, 2024

Resolves #2244, resolves #2062, resolves #2301, resolves #1135

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

New Features

  • Added v-model:expand to control expanded row state
  • Introduced multipleExpand prop (default: true) to toggle multiple/single row expansion
  • Added disabledExpand property to selectively disable row expansion
  • Added slot expand-action to customize expansion control interface

Improvements

  • Enhanced expansion
    • Added update:expand emit function
    • Improved row comparison logic to work correctly with pagination
    • Fixed bug where expanded rows persisted incorrectly between pages by replacing index-based comparison

Breaking Changes

  • Should use v-model:expand to achieve the functionality that was previously implemented using slot expand

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar
Copy link
Collaborator Author

rdjanuar commented Oct 29, 2024

i forgot to documented new props multipleExpand i added soon

@rdjanuar rdjanuar changed the title feat(Table): enhancement table expanded feat(Table): enhancement expanded row Oct 29, 2024
@rdjanuar rdjanuar changed the title feat(Table): enhancement expanded row feat(Table): enhancement expanded row Oct 29, 2024
@benjamincanac
Copy link
Member

@rdjanuar Does this replace #2063?

@rdjanuar
Copy link
Collaborator Author

yes @benjamincanac

@benjamincanac benjamincanac changed the title feat(Table): enhancement expanded row feat(Table): improve expanded row Nov 5, 2024
@benjamincanac benjamincanac merged commit 1acd01a into nuxt:dev Nov 5, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks @rdjanuar 😊 Does this imply breaking changes I should mention in the release note?

@rdjanuar
Copy link
Collaborator Author

rdjanuar commented Nov 5, 2024

yes u should @benjamincanac

@benjamincanac
Copy link
Member

Oh yes sorry, I missed the Breaking Changes section in the issue description.

@rdjanuar
Copy link
Collaborator Author

rdjanuar commented Nov 5, 2024

Hi @benjamincanac , Do you have any plans to release it today? because i use the edge package for 2 weeks :))

Copy link
Member

I am merging everything to make a release today indeed!

@rdjanuar
Copy link
Collaborator Author

rdjanuar commented Nov 5, 2024

okay thank you @benjamincanac, dont forget about this pr #2460. i really need it cause i have a lot of form that will be transform using the schema library

@benjamincanac
Copy link
Member

@rdjanuar Do you have a Discord?

@rdjanuar
Copy link
Collaborator Author

rdjanuar commented Nov 5, 2024

Yes, I have @benjamincanac. My username is rdjanuar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants