Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves #2045
β Type of change
π Description
Fixed the carousel pages calculation so that it no longer errors when the number of prop items is less than the number of calculated divisions.
The pages calculation in the carousel component returns a negative value when the number of items is less than the number of carousel divisions (calculated from the width of the carousel divided by the width of an item).
This causes the error
RangeError: Invalid array length
in the indicators template, as it is trying to runv-for="page in pages"
, wherepages
is negative.The use case which first produced this issue was a carousel of recently viewed products. Initially, there is only 1 item in the carousel, however the items widths had been setup to display multiple items, as and when the user views more products.
π Checklist