-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tabs): add content
prop to avoid the render of the HTML markup
#1831
Conversation
contentless
prop to avoid the render of the HTML markupcontentless
prop to avoid the render of the HTML markup
@@ -32,7 +32,7 @@ | |||
</HTab> | |||
</HTabList> | |||
|
|||
<HTabPanels :class="ui.container"> | |||
<HTabPanels v-if="!$props.contentless" :class="ui.container"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<HTabPanels v-if="!$props.contentless" :class="ui.container"> | |
<HTabPanels v-if="!contentless" :class="ui.container"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sorry my fault. Fixing right now.
contentless
prop to avoid the render of the HTML markupcontentless
prop to avoid the render of the HTML markup
I'm wondering if it wouldn't be better to name the prop |
That actually makes a lot of sense. I started with the |
No you can do it like this in your PR, it will avoid another breaking change π |
contentless
prop to avoid the render of the HTML markupcontent
prop to avoid the render of the HTML markup
Thanks! π |
π Linked issue
Resolves #1709
β Type of change
π Description
This prop give tha ability to the user to remove the render markup of the content completely. It may be useful in certain cases, where the user is using the
@change
event, because is changing something else, and using the tab just as a switcher component.π Checklist