Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Form): apply transformations #2460

Merged
merged 17 commits into from
Nov 5, 2024
Merged

feat(Form): apply transformations #2460

merged 17 commits into from
Nov 5, 2024

Conversation

rdjanuar
Copy link
Collaborator

@rdjanuar rdjanuar commented Oct 25, 2024 •
edited
Loading

🔗 Linked issue

Resolves #1956

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

There is an issue when using the transform method in the schema library. The transform method is not working correctly because it's emitting the props.state instead of returning the parsed value. This behavior deviates from the expected functionality of the schema library.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar rdjanuar changed the title fix(Form): mutation value in does not work fix(Form): mutation value in schema does not work Oct 25, 2024
@rdjanuar rdjanuar changed the title fix(Form): mutation value in schema does not work fix(Form): transform method in library schema does not work Oct 25, 2024
@rdjanuar rdjanuar changed the title fix(Form): transform method in library schema does not work fix(Form): transform method in library schema does not work Oct 25, 2024
@benjamincanac benjamincanac requested a review from romhml October 25, 2024 09:32
@romhml romhml changed the title fix(Form): transform method in library schema does not work feat(Form): apply state transformations Oct 27, 2024
@romhml romhml changed the title feat(Form): apply state transformations feat(Form): apply transformations Oct 27, 2024
@rdjanuar
Copy link
Collaborator Author

I updated the change request yesterday, let me know if there`s mistake of my code. thank you @romhml

@rdjanuar rdjanuar requested a review from romhml October 28, 2024 04:03
@rdjanuar rdjanuar requested a review from romhml November 2, 2024 13:55
romhml
romhml approved these changes Nov 3, 2024
View reviewed changes
Copy link
Collaborator

@romhml romhml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rdjanuar :)

@rdjanuar
Copy link
Collaborator Author

rdjanuar commented Nov 3, 2024

Do I have to update to v3? @romhml

@romhml
Copy link
Collaborator

romhml commented Nov 3, 2024

Yes if you want!

@rdjanuar
Copy link
Collaborator Author

rdjanuar commented Nov 3, 2024

i`ll update v3 soon @romhml

@benjamincanac benjamincanac merged commit ceecb60 into nuxt:dev Nov 5, 2024
2 checks passed
@rdjanuar rdjanuar mentioned this pull request Nov 5, 2024
Merged
8 tasks
@benjamincanac Volta.net
Copy link
Member

@rdjanuar No breaking changes to mention on release?

@rdjanuar
Copy link
Collaborator Author

rdjanuar commented Nov 5, 2024

nope @benjamincanac

@rdjanuar rdjanuar mentioned this pull request Nov 7, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romhml romhml romhml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UForm: apply transformations from the validator
3 participants
@rdjanuar @romhml @benjamincanac