fix(Button): props specified more than once

nuxt · Oct 1, 2024 · 66a04ad · 66a04ad
1 parent a5153d6
commit 66a04ad
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/playground/app/pages/components/button.vue b/playground/app/pages/components/button.vue
@@ -17,6 +17,11 @@ function onClick() {
         Button
       </UButton>
     </div>
+    <div class="flex items-center gap-2">
+      <UButton to="/">
+        Link
+      </UButton>
+    </div>
     <div class="flex items-center gap-2">
       <UButton disabled>
         Disabled

diff --git a/src/runtime/components/Button.vue b/src/runtime/components/Button.vue
@@ -44,6 +44,7 @@ import { useComponentIcons } from '../composables/useComponentIcons'
 import { useButtonGroup } from '../composables/useButtonGroup'
 import UIcon from './Icon.vue'
 import ULink from './Link.vue'
+import { omit } from '../utils'
 import { pickLinkProps } from '../utils/link'
 
 const props = defineProps<ButtonProps>()
@@ -92,7 +93,7 @@ const ui = computed(() => button({
     :type="type"
     :disabled="disabled || isLoading"
     :class="ui.base({ class: [props.class, props.ui?.base] })"
-    v-bind="linkProps"
+    v-bind="omit(linkProps, ['type', 'disabled'])"
     raw
     @click="onClickWrapper"
   >