Skip to content

fix(runtime): $fetch.create can't set the default configuration #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

fix(runtime): $fetch.create can't set the default configuration #1471

merged 1 commit into from
Oct 29, 2025

Conversation

@yamachi4416
Copy link
Contributor

@yamachi4416 yamachi4416 commented Oct 27, 2025 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

$fetch.create was working correctly, but it seems the issue was caused by the assertion running too early.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 27, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/test-utils@1471

commit: b7c1abc

@yamachi4416 yamachi4416 force-pushed the fetch-create-defaults branch from 4d60336 to 9f6d03e Compare October 27, 2025 11:04
@yamachi4416 yamachi4416 force-pushed the fetch-create-defaults branch from 9f6d03e to b7c1abc Compare October 27, 2025 11:21
@yamachi4416 yamachi4416 marked this pull request as ready for review October 27, 2025 11:35
danielroe
danielroe approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@danielroe danielroe merged commit a2afc9d into nuxt:main Oct 29, 2025
7 checks passed
This was referenced Oct 29, 2025
Closed
Draft
@yamachi4416 yamachi4416 deleted the fetch-create-defaults branch October 29, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yamachi4416 @danielroe