Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update TPC to v3 - abandoned #278

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 25, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
third-party-capital 2.3.0 -> 3.0.0 age adoption passing confidence

Release Notes

housseindjirdeh/third-party-capital (third-party-capital)

v3.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scripts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 9:29pm
scripts-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 9:29pm

@huang-julien huang-julien marked this pull request as draft September 25, 2024 17:52
@huang-julien huang-julien self-assigned this Sep 25, 2024
@huang-julien huang-julien changed the title chore(deps): update dependency third-party-capital to v3 feat: update third-party-capital to v3 Sep 25, 2024
@renovate renovate bot changed the title feat: update third-party-capital to v3 chore(deps): update dependency third-party-capital to v3 Sep 25, 2024
@huang-julien huang-julien changed the title chore(deps): update dependency third-party-capital to v3 feat: update TPC to v3 Sep 25, 2024
@huang-julien huang-julien marked this pull request as ready for review September 25, 2024 19:01
Copy link
Contributor Author

renovate bot commented Sep 25, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@harlan-zw
Copy link
Collaborator

Looks good, could we get some doc for the new consent options?

@renovate renovate bot changed the title feat: update TPC to v3 feat: update TPC to v3 - abandoned Sep 27, 2024
Copy link
Contributor Author

renovate bot commented Sep 27, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@huang-julien huang-julien marked this pull request as draft September 27, 2024 21:00
@huang-julien huang-julien changed the title feat: update TPC to v3 - abandoned feat: update TPC to v3 Sep 27, 2024
@huang-julien
Copy link
Member

uhh we may need to change a few things in the script generator

@@ -11,6 +11,8 @@ declare global {
export const GoogleTagManagerOptions = object({
id: string(),
l: optional(string()),
consentType: optional(string()),
consentValues: optional(string()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be object()

@renovate renovate bot changed the title feat: update TPC to v3 feat: update TPC to v3 - abandoned Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants