fix(nuxt): ignore definePageMeta warning for client only pages in dev#28246
Merged
fix(nuxt): ignore definePageMeta warning for client only pages in dev#28246
Conversation
|
|
Member
|
Is the issue here that page metadata isn't respected for client-only pages? |
Member
Author
|
The issue is that |
danielroe
approved these changes
Jul 21, 2024
Member
|
Oh, just wondering why you linked #27839. |
Merged
danielroe
pushed a commit
that referenced
this pull request
Jul 23, 2024
Kamsou
pushed a commit
to Kamsou/nuxt
that referenced
this pull request
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
Hi 👋 this PR fix an issue with #27839
Since the wrapper is being rendered as the route component for client-pages, we need to mark clientonly page components so
definePageMetacan ignore it in dev