Skip to content

fix(kit): include types in module dist/runtime/ in tsconfig file#28237

Merged
danielroe merged 2 commits intonuxt:mainfrom
HigherOrderLogic:main
Jul 21, 2024
Merged

fix(kit): include types in module dist/runtime/ in tsconfig file#28237
danielroe merged 2 commits intonuxt:mainfrom
HigherOrderLogic:main

Conversation

@HigherOrderLogic
Copy link
Copy Markdown
Contributor

🔗 Linked issue

Resolves #28224.

📚 Description

Include types in the dist folder.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Did you confirm whether it resolved the linked issue with sidebase?

@danielroe danielroe changed the title fix: include types in modules dist in tsconfig file fix(kit): include types in module dist/ in tsconfig file Jul 20, 2024
@danielroe danielroe changed the title fix(kit): include types in module dist/ in tsconfig file fix(kit): include types in module dist/runtime/ in tsconfig file Jul 20, 2024
@danielroe danielroe merged commit c0ec90d into nuxt:main Jul 21, 2024
@github-actions github-actions bot mentioned this pull request Jul 21, 2024
@trc-mathieu
Copy link
Copy Markdown

Thank you, it does fix the issue with sidebase and local modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong module resolution in tsconfig.json file

3 participants