Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(schema): initialise runtimeConfig.public with empty object #9050

Merged
merged 5 commits into from
Nov 16, 2022
Merged

fix(schema): initialise runtimeConfig.public with empty object #9050

merged 5 commits into from
Nov 16, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Lots of modules rely on this being defined.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

atinux and others added 3 commits November 16, 2022 12:19
@atinux @pi0
chore: update readme design (#9048)
568d314 
* chore: add readme assets

* chore: add social icons

* chore: implement new readme design

* chore: add gray fill

* chore: tweak social icon alignment

* chore: tweak table alignment

* Update README.md

* fix: increase quality of assets

* fix: explicit sizing for lower images

* fix: remove width

* fix: use single-column version

* Update README.md

* Update README.md

* docs: all to the left

* refactor: move assets under `.github`

make repo structure more minimal


Co-authored-by: Pooya Parsa <[email protected]>
@pi0
chore: ignore parse5 for renovate update (closes #9046)
45608c0 
pending for docs fix
@danielroe
fix(schema): initialise runtimeConfig.public
d3804bd
@danielroe danielroe added bug Something isn't working schema labels Nov 16, 2022
@danielroe danielroe requested a review from pi0 November 16, 2022 11:21
@danielroe danielroe self-assigned this Nov 16, 2022
@codesandbox
Copy link

codesandbox bot commented Nov 16, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@pi0 pi0 changed the title fix(schema): initialise runtimeConfig.public fix(schema): initialise runtimeConfig.public with empty object Nov 16, 2022
@danielroe danielroe mentioned this pull request Nov 16, 2022
Closed
@pi0 pi0 merged commit 38d7f61 into main Nov 16, 2022
@pi0 pi0 deleted the fix/empty-public branch November 16, 2022 11:42
@HigherOrderLogic HigherOrderLogic mentioned this pull request Nov 16, 2022
Closed
@danielroe danielroe added the 3.x label Jan 19, 2023
danielroe added a commit that referenced this pull request Jan 21, 2023
@danielroe
fix(schema): initialise runtimeConfig.public with empty object (#9050)
ff64c30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 left review comments

Assignees

@danielroe danielroe

Labels
3.x bug Something isn't working schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielroe @pi0 @atinux